Review Request: Fix outputview filtering/classification when there are multiple keywords in a single line

Ivan Shapovalov intelfx100 at
Thu Dec 27 15:41:35 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 27, 2012, 3:41 p.m.)

Review request for KDevelop and Morten Volden.


- fixed issues pointed out by Milian
- adopted unit-tests by Morten


Fix classification of error lines which look as
"file.cpp:100:10: error: 'SomeSymbolWithWarningInItsName' was not declared in this scope".

Here, we have an error pattern but also a "warning" keyword which actually is a part of symbol name. But existing code thinks that any appearance of "warning"/"info"/"note" in text is more important than the error pattern.

Fix this by
1) checking for all patterns in a uniform manner (loop for "string<->classification" pairs, not just for strings), and
2) picking the pattern which happened most early (to the left) in string.

Diffs (updated)

  outputview/outputfilteringstrategies.cpp 91361f1 
  outputview/tests/filteringstrategytest.h 0d9b943 
  outputview/tests/filteringstrategytest.cpp 8ff26b5 



- Built kdevplatform+kdevelop with a couple of these lines, ensured they highlight as expected;
- Improved existing unit-tests to catch the error in question.


Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list