Review Request: Fix outputview filtering/classification when there are multiple keywords in a single line

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107904/#review23969
-----------------------------------------------------------



outputview/outputfilteringstrategies.cpp
<http://git.reviewboard.kde.org/r/107904/#comment18259>

    I'd prefer if you'd add a typedef Indicator or such for the QPair and use that below instead of IndicatorVector::value_type.
    



outputview/outputfilteringstrategies.cpp
<http://git.reviewboard.kde.org/r/107904/#comment18260>

    missing &, i.e. always use const& for non-POD data types.



outputview/tests/testlinebuilderfunctions.h
<http://git.reviewboard.kde.org/r/107904/#comment18261>

    imo, instead of changing existing tests, you should add new tests.


- Milian Wolff


On Dec. 24, 2012, 8:07 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107904/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2012, 8:07 p.m.)
> 
> 
> Review request for KDevelop and Morten Volden.
> 
> 
> Description
> -------
> 
> Fix classification of error lines which look as
> "file.cpp:100:10: error: 'SomeSymbolWithWarningInItsName' was not declared in this scope".
> 
> Here, we have an error pattern but also a "warning" keyword which actually is a part of symbol name. But existing code thinks that any appearance of "warning"/"info"/"note" in text is more important than the error pattern.
> 
> Fix this by
> 1) checking for all patterns in a uniform manner (loop for "string<->classification" pairs, not just for strings), and
> 2) picking the pattern which happened most early (to the left) in string.
> 
> 
> Diffs
> -----
> 
>   outputview/outputfilteringstrategies.cpp 91361f1 
>   outputview/tests/testlinebuilderfunctions.h 3d264f7 
> 
> Diff: http://git.reviewboard.kde.org/r/107904/diff/
> 
> 
> Testing
> -------
> 
> - Built kdevplatform+kdevelop with a couple of these lines, ensured they highlight as expected;
> - Improved existing unit-tests to catch the error in question.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121225/c7bb534b/attachment.html>