Review Request: Close the outline menu in case the parent moves

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107882/#review23910
-----------------------------------------------------------

Ship it!


OK beside the useless recursion, use a loop there please.


plugins/quickopen/quickopenplugin.cpp
<http://git.reviewboard.kde.org/r/107882/#comment18233>

    Could you please rewrite this as a loop?
    
    while (widget) {
      if (ancestor == widget->parentWidget()) {
        return true;
      }
      widget = widget->parentWidget();
    }
    return false;


- Milian Wolff


On Dec. 23, 2012, 3:25 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107882/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2012, 3:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Close the outline menu in case the parent moves
> 
> Also works in case the outline toolbar is detached.
> 
> BUG: 260657
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/quickopenplugin.cpp edc743fa95a7a7edbb59d2076c76f470e12fa95a 
> 
> Diff: http://git.reviewboard.kde.org/r/107882/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121223/55546a9b/attachment.html>