Review Request: Add ordering to the project build set.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106954/#review23798
-----------------------------------------------------------

Ship it!


one small issue, then please go ahead!

thanks


project/projectbuildsetmodel.cpp
<http://git.reviewboard.kde.org/r/106954/#comment18190>

    beging+end RemoverRows should be in the helper function, just like for InsertRows in the insertItemWithCache function.


- Milian Wolff


On Dec. 20, 2012, 7:44 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106954/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2012, 7:44 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> The ordering is provided by adding another list, m_orderingCache, to the model.
> It is stored per-session and contains all elements that were added to the model (even from unloaded projects). An element is removed from the ordering cache when and only when user removes it from the model by hand.
>     
> When an element is added into the model, it is firstly looked up in the ordering cache to determine its position and, if found, it is inserted into a corresponding position.
> If not, the element is appended to both the model and the cache.
> 
> 
> Diffs
> -----
> 
>   project/projectbuildsetmodel.h c37f6af 
>   project/projectbuildsetmodel.cpp 67deb30 
>   shell/projectcontroller.cpp 8467b6a 
> 
> Diff: http://git.reviewboard.kde.org/r/106954/diff/
> 
> 
> Testing
> -------
> 
> Manual and existing unit-tests.
> 
> Do we need new unit-tests for this? If yes (and if everything else is accepted), I'll write tests.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121221/80b264b0/attachment.html>