Review Request: Fix bug 308846 Clicking on messages does not move the cursor to that location.

[Morten Volden]

> On Dec. 12, 2012, 10:03 p.m., Andreas Pakulat wrote:
> > outputview/outputfilteringstrategies.cpp, line 275
> > <http://git.reviewboard.kde.org/r/107683/diff/1/?file=98664#file98664line275>
> >
> >     Why did you change the type-check here?

Let's say that the type has already been set to e.g. warning item. Then there is no need to go in and check various error cases. 


- Morten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107683/#review23377
-----------------------------------------------------------


On Dec. 12, 2012, 9:22 p.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107683/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 9:22 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fix regression introduced when refactoring the filtering of build output. The regression meant that lines that had passed one of the regex (and were clickable) were made to be not-clickable.
> 
> This patch restores the behavior from before the refactoring, plus it makes it visible to the user that those lines are clickable. This should fix the remaining part of Bug 308846.
> 
> 
> This addresses bug 308846.
>     http://bugs.kde.org/show_bug.cgi?id=308846
> 
> 
> Diffs
> -----
> 
>   outputview/outputfilteringstrategies.cpp 567bc62 
>   outputview/tests/filteringstrategytest.cpp 116b163 
>   outputview/tests/testlinebuilderfunctions.h 17ec90d 
> 
> Diff: http://git.reviewboard.kde.org/r/107683/diff/
> 
> 
> Testing
> -------
> 
> Extended existing tests in outputfilteringstrategy
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121213/33a55763/attachment-0001.html>