Review Request: Remove duplicated code in project visitor tests

Commit Hook null at kde.org
Thu Dec 6 15:10:31 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107519/#review23070
-----------------------------------------------------------


This review has been submitted with commit 3ff9823db78dc2be6e8d1b387be5180e459a5b3e by Sergey Vidyuk to branch master.

- Commit Hook


On Nov. 29, 2012, 6:24 p.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107519/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2012, 6:24 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Move common initialization code out from tests themself and reuse same
> code for same logick.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.h 9e95426 
>   projectmanagers/cmake/tests/cmake_cmakeprojectvisitor_test.cpp 3c750f0 
> 
> Diff: http://git.reviewboard.kde.org/r/107519/diff/
> 
> 
> Testing
> -------
> 
> Run modified tests
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121206/7cbd6288/attachment.html>


More information about the KDevelop-devel mailing list