Review Request: CMake: Fix path handling bugs

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107543/#review22985
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Dec. 1, 2012, 3 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107543/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2012, 3 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> CMake: Fix path handling bugs
> 
> KUrl::isRelativeUrl() *always* returns true even in case the path is a
> absolute path (see apidocs). We want QUrl::isRelative() here.
> 
> Before this patch it was possible that even absolute paths were modified
> and folder->url() being prepended.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/cmakemanager.cpp bbde8b7eb86f94e8a05874c2862f8fd104ba2778 
> 
> Diff: http://git.reviewboard.kde.org/r/107543/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121204/6634cdc5/attachment.html>