Review Request: Fix find/replace never stopping in some cases
Milian Wolff
mail at milianw.de
Sun Dec 2 03:39:49 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107552/#review22904
-----------------------------------------------------------
Ship it!
looks clean enough, if this fixes the bug, go for it
- Milian Wolff
On Dec. 2, 2012, 1:01 a.m., Kevin Funk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107552/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2012, 1:01 a.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> Fix find/replace never stopping in some cases
>
> In case capture lists in the pattern regexp are specfied, the
> progressbar will never vanish again.
>
> BUG: 296205
>
>
> Diffs
> -----
>
> plugins/grepview/grepjob.h c357b77245f0f69314b41bc5c3a3a90048ea8ae0
> plugins/grepview/grepjob.cpp 66df1a9939c68769d3cbd75939df1ee25d136eed
>
> Diff: http://git.reviewboard.kde.org/r/107552/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Funk
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121202/5570f84f/attachment.html>
More information about the KDevelop-devel
mailing list