Review Request: Do not crash in GrepOutputModel

Kevin Funk krf at gmx.de
Sat Dec 1 16:27:00 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107548/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Do not crash in GrepOutputModel

In case there are no matches you can still trigger the replace.
=> Crash in GrepOutputmodel because it assumes the root item of the
model is still there.

Fixes:
* Disable the replace button in case there are no matches
* Do not crash in GrepoutModel in case the root item is invalid (call
  safety)

BUG: 303329


Diffs
-----

  plugins/grepview/grepoutputmodel.cpp b9d45b1b1cd59ffff246c8fc797267d22e2858c1 
  plugins/grepview/grepoutputview.cpp e19fac1fac93be24238422a410d26e1e6ed07dcc 

Diff: http://git.reviewboard.kde.org/r/107548/diff/


Testing
-------


Thanks,

Kevin Funk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121201/d30d27f6/attachment.html>


More information about the KDevelop-devel mailing list