Review Request: CMake: Fix path handling bugs

Kevin Funk krf at gmx.de
Sat Dec 1 15:00:49 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107543/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

CMake: Fix path handling bugs

KUrl::isRelativeUrl() *always* returns true even in case the path is a
absolute path (see apidocs). We want QUrl::isRelative() here.

Before this patch it was possible that even absolute paths were modified
and folder->url() being prepended.


Diffs
-----

  projectmanagers/cmake/cmakemanager.cpp bbde8b7eb86f94e8a05874c2862f8fd104ba2778 

Diff: http://git.reviewboard.kde.org/r/107543/diff/


Testing
-------


Thanks,

Kevin Funk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121201/ebcc7a8c/attachment.html>


More information about the KDevelop-devel mailing list