Re: Review Request: Find In Files — Allow depth definition instead of just recursion

[Aleix Pol Gonzalez]

> On Aug. 31, 2012, 12:10 p.m., Milian Wolff wrote:
> > sigh, now the patch contains lots of unrelated whitespace changes... See, you should just have adapted the whitespace changes to the lines you modified anyways. Now its hard to review :( Can you revert the unrelated pure-whitespace changes please and reupload the patch? (git checkout -p can help here).

Also "git diff -b" would help, instead ;)


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105856/#review18323
-----------------------------------------------------------


On Aug. 26, 2012, 11:04 a.m., Adrián Chaves Fernández wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105856/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2012, 11:04 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I got the Find In Files dialog to allow the user to specify a level of depth for the search instead of just whether it should use full depth (recursion) or none (no recursion).
> 
> This is meant to be my first step in the implementation of Find In Files for (current file and) Included Files (https://bugs.kde.org/show_bug.cgi?id=160143). Just in case I give up with the task before I finish the whole of it, I figured out it would be better to at least send you this bit now, since it is already an enhancement over the current behavior.
> 
> 
> Diffs
> -----
> 
>   plugins/grepview/grepdialog.h d4a1db6 
>   plugins/grepview/grepdialog.cpp d1f4bf7 
>   plugins/grepview/grepfindthread.h b24520c 
>   plugins/grepview/grepfindthread.cpp bc39d87 
>   plugins/grepview/grepjob.h c357b77 
>   plugins/grepview/grepjob.cpp 66df1a9 
>   plugins/grepview/grepwidget.ui 94cfb00 
>   plugins/grepview/tests/findreplacetest.cpp ac0687d 
> 
> Diff: http://git.reviewboard.kde.org/r/105856/diff/
> 
> 
> Testing
> -------
> 
> I have tested the feature by looking in “kdevplatform” for ‘All Open’ (as in “All Open Files”, one of the optiona locations for Find In Files). I tried with the following depths: Full (-1), 0, 1, 2. Only the first one and the last one gave me a match, for the file kdevplatform(0)/plugins(1)/grepview(2)/grepdialog.cpp.
> 
> I did not write an automated test for the feature, although I did updated the current tests so the changes do not break it.
> 
> Since the current tests do not actually test for different recursion values (only recursion=true), I didn’t feel like spending time on testing the change (specially since I have never written one in C++/Qt before). But if it were considered a requirement to apply the patch, I would give it a try.
> 
> 
> Thanks,
> 
> Adrián Chaves Fernández
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120831/f7037482/attachment.html>