Review Request: Add Thread and Frame Information on Execution

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105210/#review18316
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Aug. 28, 2012, 12:58 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105210/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2012, 12:58 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Moved the code that adds frame and thread information when not present in the command already from the queueCmd method to the executeCmd method and added some info at the debug strings to make clear that the queued command will be modified upon execution. This is needed in order to be able to queue commands whose information depend on previous commands in the same queue.
> 
> 
> This addresses bug 301287.
>     http://bugs.kde.org/show_bug.cgi?id=301287
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/debugsession.cpp ed3598e 
>   debuggers/gdb/unittests/gdbtest.h 3f60a74 
>   debuggers/gdb/unittests/gdbtest.cpp 56c69f3 
> 
> Diff: http://git.reviewboard.kde.org/r/105210/diff/
> 
> 
> Testing
> -------
> 
> 1. Set up a breakpoint in a debug project
> 2. Add a variable to the watch list
> 3. Check the debugging output about the queued command and executed command.
> 
> Previously, these two would be the same. After this patch, the executed command has the --thread and --frame parameters.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120831/719c5d78/attachment.html>