Review Request: Fixed crash in the ProjectSourcePage when a NULL job has been returned.

Aleix Pol Gonzalez aleixpol at gmail.com
Fri Aug 17 12:47:23 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106059/#review17596
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Aug. 17, 2012, 11:25 a.m., Miquel Sabaté wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106059/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2012, 11:25 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> In the KDE project provider, if you do not select a repository, the createWorkingCopy method returns a NULL job, which is ok. However, in kdevplatform there's a Q_ASSERT that makes kdevelop to crash in this situation. Instead of crashing, do nothing.
> 
> 
> Diffs
> -----
> 
>   shell/projectsourcepage.cpp 7707ad1 
> 
> Diff: http://git.reviewboard.kde.org/r/106059/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Miquel Sabaté
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120817/9194d573/attachment.html>


More information about the KDevelop-devel mailing list