Review Request: Crash fix on empty config

[Andreas Pakulat]

> On May 13, 2012, 9:08 a.m., Andreas Pakulat wrote:
> > Hmm, shouldn't the enter-press simply add the config? At least that sounds more sane than being able to type something and then have either nothing happen or everything enabled and nothing is saved to disk later on.
> 
> Milian Wolff wrote:
>     will you take care of this? or has this been applied already?
>     
>     if the user can still trigger the assertion this should be fixed.

The code has changed significantly now, I'll retry it over the weekend. I'm not going to add the patch as is, since its wrong IMHO.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104927/#review13766
-----------------------------------------------------------


On May 13, 2012, 2:56 a.m., György Andrasek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104927/
> -----------------------------------------------------------
> 
> (Updated May 13, 2012, 2:56 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fixes crash when the user is trying to add the first configuration: types name and presses Enter on the combobox instead of the Add button.
> 
> Assert is triggered with idx == 0, configs.size() == 0.
> 
> 
> Diffs
> -----
> 
>   custombuildsystemconfigwidget.cpp 791b7c7 
> 
> Diff: http://git.reviewboard.kde.org/r/104927/diff/
> 
> 
> Testing
> -------
> 
> Works For Me (tm)
> 
> 
> Thanks,
> 
> György Andrasek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120817/ccc84748/attachment.html>