Review Request: Replace lockfile remove dialog code with call to existing code in kdevplatform.

[Ivan Shapovalov]

> On Aug. 16, 2012, 7:28 p.m., Milian Wolff wrote:
> > app/main.cpp, line 90
> > <http://git.reviewboard.kde.org/r/105918/diff/1/?file=76523#file76523line90>
> >
> >     please add a short documentation (i.e. data is compared to name or uuid of session, match is returned).
> >     
> >     also, I'd rather you return-by-value and check e.g. name.isEmpty() for whether a valid session was found or not.

Added documentation, but I need to retrieve both session's name and UUID (to pass to the dialog), so IMO using SessionInfo* is optimal.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105918/#review17552
-----------------------------------------------------------


On Aug. 7, 2012, 7:02 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105918/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 7:02 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Remove the lockfile remove dialog in KDevelop's main() which has been moved to kdevplatform in https://git.reviewboard.kde.org/r/105917/ .
> 
> Instead of completely removing it, replace it with an early call to the same code in kdevplatform.
> This allows to do early checks without creating a splash and going to Core::initialize() when a session name is explicitly given in arguments.
> 
> 
> Diffs
> -----
> 
>   app/main.cpp 636a7a7 
> 
> Diff: http://git.reviewboard.kde.org/r/105918/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests + manual UI testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120816/f277c519/attachment.html>