Review Request: Delete old CMake cache model when switching build directories

Commit Hook null at kde.org
Tue Aug 7 16:13:30 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105912/#review17051
-----------------------------------------------------------


This review has been submitted with commit b24ddc53696219000c361dee7dc7b6b89f5c4de0 by Ivan Shapovalov to branch master.

- Commit Hook


On Aug. 7, 2012, 3:27 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105912/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 3:27 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Call ->deleteLater() on old CMake cache model when a new one is going to be created. Why keep garbage?
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/settings/cmakepreferences.cpp 76694ce 
> 
> Diff: http://git.reviewboard.kde.org/r/105912/diff/
> 
> 
> Testing
> -------
> 
> Unit-tests and manual UI testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120807/bbb6a545/attachment.html>


More information about the KDevelop-devel mailing list