Review Request: Separate CMake cache view reconfiguration into a separate function.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105915/#review17049
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Aug. 7, 2012, 3:40 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105915/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 3:40 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This allows us to connect the new function to model reset signal and avoid re-creating model object after reconfiguring project when there is a model already.
>     
> Also, the new function has been made to emit changed(false) since using "Apply" in CMake KCM results in
> reconfiguring -> re-reading file -> changing model -> emitting changed(true) per each item change, so "Apply" gets active again.
> This isn't what we want.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/settings/cmakepreferences.h f99802d 
>   projectmanagers/cmake/settings/cmakepreferences.cpp 76694ce 
> 
> Diff: http://git.reviewboard.kde.org/r/105915/diff/
> 
> 
> Testing
> -------
> 
> Manual UI testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120807/61c73fc9/attachment.html>