Review Request: Emit *resetModel() when the CMake cache model is being reset
Aleix Pol Gonzalez
aleixpol at gmail.com
Tue Aug 7 15:53:03 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105913/#review17047
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Aug. 7, 2012, 3:29 p.m., Ivan Shapovalov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105913/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2012, 3:29 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> Emit beginResetModel()/endResetModel() in CMakeCacheModel::reset().
> That's just per Qt docs.
>
>
> Diffs
> -----
>
> projectmanagers/cmake/settings/cmakecachemodel.cpp bdff937
>
> Diff: http://git.reviewboard.kde.org/r/105913/diff/
>
>
> Testing
> -------
>
> Existing unit-tests + manual UI testing, nothing broke.
>
>
> Thanks,
>
> Ivan Shapovalov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120807/fa05e954/attachment.html>
More information about the KDevelop-devel
mailing list