Review Request: Set CMake cache model header data on model reset.

Ivan Shapovalov intelfx100 at gmail.com
Tue Aug 7 15:32:37 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105914/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

When CMake cache model is being reset (CMakeCacheModel::reset()), it's being clear()'ed and then read(); clear() deletes not only the data but also header labels; but they had been set in ctor only.
Fix this by moving header configuration to read() which is called from both ctor and reset().


Diffs
-----

  projectmanagers/cmake/settings/cmakecachemodel.cpp bdff937 

Diff: http://git.reviewboard.kde.org/r/105914/diff/


Testing
-------

Existing unit-tests + manual UI testing.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120807/cf8fc588/attachment.html>


More information about the KDevelop-devel mailing list