Review Request: Use single-char QString operations for efficiency (fixes 53 issues to the krazy checks).

[Ghislain Mary]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104772/
-----------------------------------------------------------

(Updated April 29, 2012, 9:46 p.m.)


Review request for KDevelop.


Changes
-------

Add file attachment.


Description
-------

Use single-char QString operations for efficiency (fixes 53 issues to the krazy checks).


Diffs
-----

  debugger/framestack/framestackmodel.cpp 17eba1ab5ad1bf9be813c41bea7427dd5c285bac 
  language/codegen/applychangeswidget.cpp 6d6df915615a494f267c86cf36a7359547beb68b 
  language/codegen/documentchangeset.cpp 74de81deb3cb355b776bd854bcac992a8f6f9b97 
  language/duchain/repositories/itemrepository.cpp d9e247240d4b49f921ac72137f073cbffdacf64a 
  language/duchain/stringhelpers.cpp e384294ea94420a091ecf5ae9947dcfadc2aa100 
  language/editor/modificationrevisionset.cpp 6c20946e308c98b0dcb713892af8d12f504395de 
  plugins/appwizard/projectselectionpage.cpp e71e492d3d5a62b89986a45d37ca3ce88b6805b3 
  plugins/documentswitcher/documentswitcherplugin.cpp d572ed6cc56f82dc13b75950629f2450e8153e06 
  plugins/genericprojectmanager/genericmanager.cpp fc6d02999f9606c6f522d515d8112f13f7ab054e 
  plugins/genericprojectmanager/test/reloadtest.cpp bf796979262d4ba7c17e2990e56181ae3c28edd6 
  plugins/git/tests/initTest.cpp 28eb55976d38233e28a9b9241b7ed1b3fce7801f 
  plugins/grepview/grepdialog.cpp b4b8cf5c2218ca34a870d785f99f34aa00ec39a8 
  plugins/grepview/grepoutputview.cpp b18be76eaf2f88310e96dc3906b40a3d316a9bed 
  plugins/konsole/kdevkonsoleview.cpp 1cf06e8fd3e19df8acbbf47d1c23bde933c0942f 
  plugins/patchreview/libdiff2/tests/levenshteintest.cpp 8029cf20cdda5b20b14e30c487a1f8de84b6b61e 
  plugins/problemreporter/problemwidget.cpp 188620a85d1a8d616f3c9f954f01b57877a9df5f 
  plugins/projectmanagerview/projectmodelsaver.cpp 0d3cab39e6196547fb4afff3c1760c9064f5cffd 
  plugins/snippet/snippetfilterproxymodel.cpp 694761a9cf2c80d5d70cb5355d1e65c9e6247ceb 
  plugins/standardoutputview/outputwidget.cpp daf9bd20e02048f8900fd039e41154481ffca8a4 
  plugins/subversion/kdevsvncpp/client_cat.cpp e8ce05c251f2c6a6bd026b64aad12c0d1c4e2b56 
  plugins/subversion/kdevsvncpp/client_modify.cpp b32d81773321a6b0a94b536352fbce164d75dda0 
  plugins/subversion/kdevsvncpp/client_status.cpp a77ebbd6465ed873742e6225d0a05011ad7cad4b 
  plugins/subversion/kdevsvncpp/exception.cpp bbff0bdbb84d003c0ff4bf7e0d2afd893c6c3422 
  plugins/subversion/svndiffjob.cpp 76aceb53d9254e7cd0cc6baf1180d9bb6b189b8e 
  plugins/subversion/svnimportmetadatawidget.cpp fec07fc9469d01639e2583a38b789bc3e3b9e47f 
  plugins/subversion/tests/svnimport.cpp 5ce6df532e0f2ec46643bfa4135ee361362e35e7 
  shell/sessioncontroller.cpp 36322b842bf8716e421d1dd827b1f4ee970b3d2c 
  shell/sourceformattercontroller.cpp 071f8e7bb3c18569bcaf1944a6eec71de4a5409d 
  shell/tests/projectcontrollertest.cpp 94f73396aed6b21239ef319a8a0a0731cfad57cc 
  shell/tests/sessioncontrollertest.cpp d916cbb12b59bab88b665607a4623ec5325cd112 
  shell/workingsets/workingsettoolbutton.cpp 051027f64c87c99213ae3d2405caf1f7d7c5b785 
  sublime/container.cpp c34c02c060a5050b149266f708ba0940eb831e3e 
  sublime/ideal.cpp e32d73e07c77b8f30bbb656dea9e44063272e4ec 
  util/commandexecutor.cpp 79c9343c9ee54e3932717f2f055edc651f537a64 
  util/duchainify/main.cpp d559361539dfcc646a65c43a846b7155866cb0ab 
  util/formattinghelpers.cpp dd2f990f765ac17234edbce4f157c23fe816b797 

Diff: http://git.reviewboard.kde.org/r/104772/diff/


Testing
-------


Thanks,

Ghislain Mary

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120429/fbf89c9a/attachment.html>