Review Request: Add support for cmake target include_directories.
Ben Wagner
bungeman at gmail.com
Sun Apr 29 05:31:59 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104777/
-----------------------------------------------------------
(Updated April 29, 2012, 5:31 a.m.)
Review request for KDevelop.
Description
-------
With CMake 2.8.8, it is now possible to write something like
set_property(TARGET zlib APPEND PROPERTY INCLUDE_DIRECTORIES "include/config")
This change implements include directories on targets.
Note that I am not a committer, so if you want it, the diff I uploaded is a format-patch against current master.
This addresses bug 298859.
http://bugs.kde.org/show_bug.cgi?id=298859
Diffs
-----
projectmanagers/cmake/cmakemanager.cpp 9ae8f90
projectmanagers/cmake/cmakemodelitems.h 705a632
projectmanagers/cmake/cmakemodelitems.cpp 957c410
Diff: http://git.reviewboard.kde.org/r/104777/diff/
Testing
-------
Built and ran. The test linked from bug works as expected after building (as the test itself generates some of the required .h files). Behavior of non-target includes appears unaffected.
Thanks,
Ben Wagner
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120429/c85f3ac4/attachment.html>
More information about the KDevelop-devel
mailing list