Review Request: KDevelop rewrite the .kdev4 file after opening a project and replaces the project name with the directory name

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104641/#review13036
-----------------------------------------------------------



shell/projectcontroller.cpp
<http://git.reviewboard.kde.org/r/104641/#comment10143>

    this invariant will break with your change, can you test it?


- Milian Wolff


On April 17, 2012, 6:26 a.m., Bastian Leyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104641/
> -----------------------------------------------------------
> 
> (Updated April 17, 2012, 6:26 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> KDevelop rewrite the .kdev4 file after opening a project.
> The project name I entered in the project information dialog is replaced with the directory name.
> 
> 
> Steps to Reproduce:
> 1. Create a project directory named "myproject"
> 2. Create in the project directory the directories "trunk" and "branches"
> 3. Create in the "trunk" directory a file named "makefile"
> 4. Import the Project by selecting the makefile
> 5. Enter the project name "My Project" in the "Project information" dialog
> 6. Everything's fine. KDevelop shows in the 'Projects' toolview the correct project name
> 7. Close the project
> 8. Reopen the project by selecting the .kdev4 file in the trunk directory
> 9. Oops...now the project is named "trunk"
> 10. Look into the .kdev4 file. The project configuration now contains the project name "trunk"
> 
> another scenario:
> 1. Select Project->New From Template
> 2. Choose a "Standard Terminal" application
> 3. Use the project name "myproject"
> 4. Ignore the "Version Control" Page and finish the wizard
> 5. Use the "build directory" default settings
> 6. The new project is now shown as "myproject"
> 7. Close the project
> 8. Rename the project directory to "foobar"
> 9. Reopen the project with the .kdev4 file
> 10. Now the project is named "foobar"
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=298263.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=298263
> 
> 
> Diffs
> -----
> 
>   shell/projectcontroller.cpp 38084df 
> 
> Diff: http://git.reviewboard.kde.org/r/104641/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bastian Leyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120428/7bcccfc0/attachment.html>