Review Request: Add history for extra arguments in the build directory configuration dialog.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104755/#review12996
-----------------------------------------------------------


some small nitpicks, please adress them then add the patch as created by "git format-patch" using the "add file" action in the menu of this review request

also: could the same be done for the installation prefix?


projectmanagers/cmake/cmakebuilddirchooser.cpp
<http://git.reviewboard.kde.org/r/104755/#comment10113>

    add an In: maxExtraArguments*In*History



projectmanagers/cmake/cmakebuilddirchooser.cpp
<http://git.reviewboard.kde.org/r/104755/#comment10111>

    what if that item is the current one? then it would be twice in that list, no?



projectmanagers/cmake/cmakebuilddirchooser.cpp
<http://git.reviewboard.kde.org/r/104755/#comment10112>

    paired with the comment above: rather check that in the loop and change the iteration condition such that at most maxExtraArgumentsHistory *unique* items are added


- Milian Wolff


On April 27, 2012, 12:35 p.m., Ghislain Mary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104755/
> -----------------------------------------------------------
> 
> (Updated April 27, 2012, 12:35 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Add history for extra arguments in the build directory configuration dialog.
> 
> 
> This addresses bug 258990.
>     http://bugs.kde.org/show_bug.cgi?id=258990
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/cmakebuilddirchooser.h 4f16645938b503b28549577677fe80326a82f33d 
>   projectmanagers/cmake/cmakebuilddirchooser.cpp a6cce8885132c6429edfc321e147c8e323ce18d7 
>   projectmanagers/cmake/cmakebuilddirchooser.ui 0e9a2aefce4608f2ce39619677e4588dc83c1182 
> 
> Diff: http://git.reviewboard.kde.org/r/104755/diff/
> 
> 
> Testing
> -------
> 
> Add a build directory with some extra arguments.
> Then add another build directory, and the previous extra arguments can be selected from the history.
> 
> 
> Thanks,
> 
> Ghislain Mary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120427/640421aa/attachment.html>