Review Request: Improve QuickOpen system to sort items based on typed text

Victor Vicente Carvalho victor.v.carvalho at gmail.com
Thu Apr 19 23:05:18 UTC 2012



> On April 19, 2012, 10:37 p.m., Milian Wolff wrote:
> > note: I've already fixed a bug that lead to randomly changing order that was apparent in your "player" example: when one typed "player" the items changed their order randomly on each char - not any more.
> > 
> > I've also cleaned up the file a bit, many thanks for your contribution!
> 
> Milian Wolff wrote:
>     oh and: I'd like to see this behavior also when filtering in the outline view... could we share the code and make this happen? I'd like to see a patch :)

Well, I think that it's already working, as David mentioned both views share it. At least on my kdevelop the functions are sorted right, like when I type the class name it already shows up as the first item. 


- Victor Vicente


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103955/#review12689
-----------------------------------------------------------


On April 18, 2012, 3:38 a.m., Victor Vicente Carvalho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103955/
> -----------------------------------------------------------
> 
> (Updated April 18, 2012, 3:38 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Improve QuickOpen system to sort items based on a right-to-left approach, putting items that are close to the typed text next to the first matches. This is achieved through a weighted sorter on the ProjectItemDataProvider filter.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/projectitemquickopen.cpp e1055d2a546ac2caf9bdfe5071e3a0cb924e1065 
> 
> Diff: http://git.reviewboard.kde.org/r/103955/diff/
> 
> 
> Testing
> -------
> 
> Ran kdevelop over several projects, no problems so far.
> 
> 
> Thanks,
> 
> Victor Vicente Carvalho
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120419/8f7495bb/attachment.html>


More information about the KDevelop-devel mailing list