Review Request: Add a new search flag for not resolving alias declarations, and fix a bug with range comparisons

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104628/#review12572
-----------------------------------------------------------



language/duchain/ducontext.h
<http://git.reviewboard.kde.org/r/104628/#comment9846>

    The comment could be more straightforward: "Disables the resolution of alias declarations in the returned list" or similar



language/duchain/ducontext.cpp
<http://git.reviewboard.kde.org/r/104628/#comment9847>

    This could be done simpler: Just move the top-context and range-check up here with a "return 0", and then add "&& !(flags & DontResolveAliases)" to the check below. Then the two new variables are not required.


- David Nolden


On April 16, 2012, 10:28 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104628/
> -----------------------------------------------------------
> 
> (Updated April 16, 2012, 10:28 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> As discussed on the mailing list:
> 1) Add a new search flag to tell findDeclarations to not resolve AliasDeclarations
> 2) Fix a bug with range comparisons if the declaration is an alias declaration aliasing a declaration from a different top-context
> 
> 
> Diffs
> -----
> 
>   language/duchain/ducontext.h f4fa7c1 
>   language/duchain/ducontext.cpp 0b6dc75 
> 
> Diff: http://git.reviewboard.kde.org/r/104628/diff/
> 
> 
> Testing
> -------
> 
> Used it for a few days, no bugs discovered.
> cpp duchain tests still all pass.
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120417/84d4a569/attachment.html>