Review Request: Improve QuickOpen system to sort items based on typed text

[Milian Wolff]

> On April 16, 2012, 9:53 p.m., Milian Wolff wrote:
> > plugins/quickopen/projectitemquickopen.cpp, line 186
> > <http://git.reviewboard.kde.org/r/103955/diff/2/?file=56830#file56830line186>
> >
> >     unrelated change (more further down)
> 
> Victor Vicente Carvalho wrote:
>     I ran the "reformat source" command, how do I revert these changes?

either by hand or by using "git checkout -p"


> On April 16, 2012, 9:53 p.m., Milian Wolff wrote:
> > plugins/quickopen/projectitemquickopen.cpp, line 130
> > <http://git.reviewboard.kde.org/r/103955/diff/2/?file=56830#file56830line130>
> >
> >     why? could you answer that also in the comment?
> 
> Victor Vicente Carvalho wrote:
>     Iterating from the last item to the first is more efficient, as we want to match the class/function name, which is the last item on the search fields and on the identifier.

yes, please add this information to the comment


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103955/#review12539
-----------------------------------------------------------


On April 17, 2012, 1:03 a.m., Victor Vicente Carvalho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103955/
> -----------------------------------------------------------
> 
> (Updated April 17, 2012, 1:03 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Improve QuickOpen system to sort items based on a right-to-left approach, putting items that are close to the typed text next to the first matches. This is achieved through a weighted sorter on the ProjectItemDataProvider filter.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/projectitemquickopen.cpp e1055d2a546ac2caf9bdfe5071e3a0cb924e1065 
> 
> Diff: http://git.reviewboard.kde.org/r/103955/diff/
> 
> 
> Testing
> -------
> 
> Ran kdevelop over several projects, no problems so far.
> 
> 
> Thanks,
> 
> Victor Vicente Carvalho
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120417/0174e7f7/attachment.html>