Review Request: Improve QuickOpen system to sort items based on typed text

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103955/#review12539
-----------------------------------------------------------

Ship it!


looks really good now imo, but please do some style-reviewing. then upload the file as created by "git format-patch"

cheers


plugins/quickopen/projectitemquickopen.cpp
<http://git.reviewboard.kde.org/r/103955/#comment9823>

    remove trailing spaces please (here and in all the lines below)



plugins/quickopen/projectitemquickopen.cpp
<http://git.reviewboard.kde.org/r/103955/#comment9824>

    why? could you answer that also in the comment?



plugins/quickopen/projectitemquickopen.cpp
<http://git.reviewboard.kde.org/r/103955/#comment9825>

    according *to their* distance



plugins/quickopen/projectitemquickopen.cpp
<http://git.reviewboard.kde.org/r/103955/#comment9826>

    unrelated change (more further down)


- Milian Wolff


On April 16, 2012, 8:40 p.m., Victor Vicente Carvalho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103955/
> -----------------------------------------------------------
> 
> (Updated April 16, 2012, 8:40 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Improve QuickOpen system to sort items based on a right-to-left approach, putting items that are close to the typed text next to the first matches. This is achieved through a weighted sorter on the ProjectItemDataProvider filter.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/projectitemquickopen.cpp e1055d2a546ac2caf9bdfe5071e3a0cb924e1065 
> 
> Diff: http://git.reviewboard.kde.org/r/103955/diff/
> 
> 
> Testing
> -------
> 
> Ran kdevelop over several projects, no problems so far.
> 
> 
> Thanks,
> 
> Victor Vicente Carvalho
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120416/0b1ef6ed/attachment.html>