Review Request: Improve QuickOpen system to sort items based on typed text

[Victor Vicente Carvalho]

> On April 15, 2012, 9:55 p.m., Milian Wolff wrote:
> > hmm trying it out - what should I notice? could you give an example please, maybe with some example file?

Just hit Ctrl+alt+C to open the class quickopen menu, and try finding any class. With the path, the closest named classes will appear as the first items whereas on kdevelop without the patch the items will be ordered on lexicographical order - which is not desired. The best way to notice it is to try to match a class that has the same name as namespace, like (these classes are from a game I'm developing):

player::Ball
player::Arm
player::Crane
player::Crawler
player::Player

Looking for "player" will display the items in this exact order, whereas with the path they will be displayed as:

player::Player
player::Crane
player::Arm
player::Crawler
player::Ball

Putting the desired class, not the namespace as the preferred item.


- Victor Vicente


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103955/#review12490
-----------------------------------------------------------


On April 15, 2012, 8:44 p.m., Victor Vicente Carvalho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103955/
> -----------------------------------------------------------
> 
> (Updated April 15, 2012, 8:44 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Improve QuickOpen system to sort items based on a right-to-left approach, putting items that are close to the typed text next to the first matches. This is achieved through a weighted sorter on the ProjectItemDataProvider filter.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/projectitemquickopen.cpp 1caadffee64051a0d77d7a65a97ff86b33a78d39 
> 
> Diff: http://git.reviewboard.kde.org/r/103955/diff/
> 
> 
> Testing
> -------
> 
> Ran kdevelop over several projects, no problems so far.
> 
> 
> Thanks,
> 
> Victor Vicente Carvalho
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120416/d28c458b/attachment.html>