Review Request: Fix Project Listing in Reviewboard Plugin

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104601/#review12493
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On April 15, 2012, 6:56 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104601/
> -----------------------------------------------------------
> 
> (Updated April 15, 2012, 6:56 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Turns out that the Reviewboard API returns a max of 200 results regardless of what you set as max-results in the request, so we need to fetch the list incrementally. I'm not sure of how should the HttpPostCall be deleted, I think the way it is implemented here leaks every call, right?
> 
> 
> Diffs
> -----
> 
>   plugins/reviewboard/reviewboardjobs.h 4dafdb0 
>   plugins/reviewboard/reviewboardjobs.cpp 8539802 
>   plugins/reviewboard/tests/CMakeLists.txt eb0c950 
> 
> Diff: http://git.reviewboard.kde.org/r/104601/diff/
> 
> 
> Testing
> -------
> 
> Before this patch, 154 repositories were not listed, e.g. kig, simon, cantor, dragon, marble, rocs, parley... these all show in the filtered list widget after this patch.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120416/5b477014/attachment.html>