Review Request: Parser support for C99 designated initializers

Milian Wolff mail at milianw.de
Sun Apr 15 11:42:50 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103448/#review12463
-----------------------------------------------------------


please get rid of the goto and then I'm fine with this patch (sorry, should have said that sooner)


languages/cpp/parser/parser.cpp
<http://git.reviewboard.kde.org/r/103448/#comment9774>

    please add a newline after this line



languages/cpp/parser/parser.cpp
<http://git.reviewboard.kde.org/r/103448/#comment9775>

    please don't use goto, just copy the rewind + return clause here
    
    though actually there is afaiks even a macro defined that checks the lookahead + returns on error



languages/cpp/parser/parser.cpp
<http://git.reviewboard.kde.org/r/103448/#comment9776>

    no goto please



languages/cpp/parser/parser.cpp
<http://git.reviewboard.kde.org/r/103448/#comment9777>

    please get rid of this


- Milian Wolff


On April 15, 2012, 7:20 a.m., Alexandre Courbot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103448/
> -----------------------------------------------------------
> 
> (Updated April 15, 2012, 7:20 a.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Description
> -------
> 
> Parser support for C99 designated initializers
> 
> Support C99 initializers in the C++ parser, e.g:
> 
> struct foo_t foo = {
>   .has_cake = true,
>   .nb_candles = 12,
> };
> 
> int bar[10] = {
>   [1] = 15,
>   [9] = 25,
> };
> 
> REVIEW: 103448
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/parser.h 64b5c505866ac2a0ed847aa67e4c7809df3af6b5 
>   languages/cpp/parser/parser.cpp a45ee31a1207d56efef292babb2e774b51378ead 
>   languages/cpp/parser/tests/test_parser.h 2869d9ddae2632aced2f2e2fa966382da3a0082d 
>   languages/cpp/parser/tests/test_parser.cpp 94e3ee06dc9187568c000dcdd8baf8d87d1d06e6 
> 
> Diff: http://git.reviewboard.kde.org/r/103448/diff/
> 
> 
> Testing
> -------
> 
> Used it for a couple of weeks, ensured the parser tests all pass.
> 
> 
> Thanks,
> 
> Alexandre Courbot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120415/32d3ae72/attachment.html>


More information about the KDevelop-devel mailing list