Review Request: Fix Project Listing in Reviewboard Plugin

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104601/
-----------------------------------------------------------

(Updated April 15, 2012, 6:56 a.m.)


Review request for KDevelop.


Changes
-------

Removed one HTTP Post call which is not needed, since the info can be obtained from the JSON result and we are going to fetch repositories incrementally anyways. Also registered post calls in core's job tracker so no job pointer is now kept as attribute.


Description
-------

Turns out that the Reviewboard API returns a max of 200 results regardless of what you set as max-results in the request, so we need to fetch the list incrementally. I'm not sure of how should the HttpPostCall be deleted, I think the way it is implemented here leaks every call, right?


Diffs (updated)
-----

  plugins/reviewboard/reviewboardjobs.h 4dafdb0 
  plugins/reviewboard/reviewboardjobs.cpp 8539802 
  plugins/reviewboard/tests/CMakeLists.txt eb0c950 

Diff: http://git.reviewboard.kde.org/r/104601/diff/


Testing
-------

Before this patch, 154 repositories were not listed, e.g. kig, simon, cantor, dragon, marble, rocs, parley... these all show in the filtered list widget after this patch.


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120415/a9f5ad51/attachment.html>