Review Request: GDB output window sometimes inserts into middle.

Ben Wagner bungeman at gmail.com
Fri Apr 13 16:04:16 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104559/
-----------------------------------------------------------

(Updated April 13, 2012, 4:04 p.m.)


Review request for KDevelop.


Changes
-------

Use the right patch.


Description
-------

The GDB output window inserts responses from GDB at the current cursor location. If one clicks in the middle of the widget or selects some text, the next GDB output will be inserted there instead of appended to the end. This is rather frustrating. This patch makes it so that GDB output is always appended to the end.

This is related to https://bugs.kde.org/show_bug.cgi?id=229865 .


Diffs
-----

  debuggers/gdb/gdboutputwidget.cpp 93b5e75 

Diff: http://git.reviewboard.kde.org/r/104559/diff/


Testing
-------

Built and ran locally. Confirmed that this fixes the issue. I am not very experienced with Qt, so I am basing this off of the example at http://doc.qt.nokia.com/4.7-snapshot/richtext-cursor.html#manipulating-rich-text so there may be some better means of doing this.


Thanks,

Ben Wagner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120413/5faf9659/attachment.html>


More information about the KDevelop-devel mailing list