Review Request: C99 designated initializers (fix)

[Ivan Shapovalov]

> On April 13, 2012, 10:56 a.m., Milian Wolff wrote:
> > languages/cpp/parser/parser.cpp, line 2776
> > <http://git.reviewboard.kde.org/r/104557/diff/1/?file=56379#file56379line2776>
> >
> >     you should enable the language debug area in kdebugdialog, then run kdevelop, reproduce the loop and see which file was getting parsed. then attach gdb and get a backtrace. oh and once knowing which file produces the error, try to run duchainify on it and see whether it also hangs up on it. if so - reduce the file size and create a proper unit test
> 
> Alexandre Courbot wrote:
>     Thanks, I did not know about kdebugdialog and duchainify and they have been very useful. The issue was due to poor programming from my part. Statements like:
>     
>     !session->token_stream->lookAhead() == ']'
>     
>     are indeed always false and should be rewritten to
>     
>     session->token_stream->lookAhead() != ']'
>     
>     to have the intended effect. Brown bag for me here. After fixing these things work much better. I will refine the unit tests and submit a new version of the patch.

Oh. I didn't notice this either. So I guess I'm closing this review request now?


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104557/#review12387
-----------------------------------------------------------


On April 13, 2012, 1:18 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104557/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 1:18 a.m.)
> 
> 
> Review request for KDevelop and Alexandre Courbot.
> 
> 
> Description
> -------
> 
> Fix of this patch:
> https://git.reviewboard.kde.org/r/103448
> 
> Passes unit-tests and "QString" testcase.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/parser.h 64b5c50 
>   languages/cpp/parser/parser.cpp a45ee31 
>   languages/cpp/parser/tests/test_parser.h 2869d9d 
>   languages/cpp/parser/tests/test_parser.cpp 94e3ee0 
> 
> Diff: http://git.reviewboard.kde.org/r/104557/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120414/9c0e68d7/attachment.html>