Review Request: Memory viewer fixes.

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104574/#review12404
-----------------------------------------------------------


Two more comments I better move from my brain to the reviewboard.


debuggers/gdb/memviewdlg.cpp
<http://git.reviewboard.kde.org/r/104574/#comment9716>

    BTW: All this red markers should give you a hint that you better tell your editor to show trailing spaces, so you can remove them before you publish your diff ;)
    
    



debuggers/gdb/memviewdlg.cpp
<http://git.reviewboard.kde.org/r/104574/#comment9719>

    IMHO all of these settings would ideally be only done once, in MemoryView::initWidget().
    
    Moving setAutoDelete(false) there as well should be okay, as at least with Okteta for default data of size 0 there has not been any memory allocated internally.
    
    (Just checked: the used ByteArrayModelPrivate constructor has
       mData( (size>0) ? new Byte[size] : 0 )
    so all fine :) )
    


- Friedrich W. H. Kossebau


On April 13, 2012, 12:19 a.m., Ben Wagner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104574/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 12:19 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This is a somewhat odd patch, since it changes what is currently dead code. However, uncommenting the relevant portions of debuggerplugin.* and CMakeLists in debuggers/gdb allows it to be used. This change makes the memory viewer at least work and not crash, which is an improvement over the existing state. This code needs more work before being re-enabled, as does the code which calls it (it is rather strange the way it's UI is set up). However, this is a good checkpoint.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/memviewdlg.h 1629cd0 
>   debuggers/gdb/memviewdlg.cpp 0500a21 
> 
> Diff: http://git.reviewboard.kde.org/r/104574/diff/
> 
> 
> Testing
> -------
> 
> Got it working. Used it. When Okteta is installed it works and I haven't gotten it to crash again yet.
> 
> 
> Thanks,
> 
> Ben Wagner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120413/da2cd576/attachment.html>