Review Request: GDB output window sometimes inserts into middle.

[Milian Wolff]

> On April 13, 2012, 11:04 a.m., Milian Wolff wrote:
> > sounds good
> 
> Ben Wagner wrote:
>     I'm not currently a committer, and I'm not entirely sure what the bar for that is. In any event, I am unable to commit this myself at the moment.

then please upload the patch as created by "git format-patch" to this review request (see "add file" in the menu above).


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104559/#review12389
-----------------------------------------------------------


On April 12, 2012, 4:19 p.m., Ben Wagner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104559/
> -----------------------------------------------------------
> 
> (Updated April 12, 2012, 4:19 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> The GDB output window inserts responses from GDB at the current cursor location. If one clicks in the middle of the widget or selects some text, the next GDB output will be inserted there instead of appended to the end. This is rather frustrating. This patch makes it so that GDB output is always appended to the end.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/gdboutputwidget.cpp 93b5e75 
> 
> Diff: http://git.reviewboard.kde.org/r/104559/diff/
> 
> 
> Testing
> -------
> 
> Built and ran locally. Confirmed that this fixes the issue. I am not very experienced with Qt, so I am basing this off of the example at http://doc.qt.nokia.com/4.7-snapshot/richtext-cursor.html#manipulating-rich-text so there may be some better means of doing this.
> 
> 
> Thanks,
> 
> Ben Wagner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120413/03da331d/attachment.html>