Review Request: C99 designated initializers (fix)

[Ivan Shapovalov]

> On April 13, 2012, 8:49 a.m., Alexandre Courbot wrote:
> > languages/cpp/parser/parser.cpp, line 2776
> > <http://git.reviewboard.kde.org/r/104557/diff/1/?file=56379#file56379line2776>
> >
> >     Unfortunately the parser seems to enter an infinite loop that allocates memory until it gets killed with I parse the Linux kernel with this. Inverting the true and false parameters seems to fix the issue, but this tends to indicate something can go terribly wrong in parseDesignatedInitializer. Any suggestion as to how I could figure out the faulty code that drives the parser crazy?

Uhm.. I did not test it on the kernel code. Does the loop happen with true-then-false order or vice versa?

Anyway, I will now attempt to trace the parser to see which rules actually create the loop body.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104557/#review12383
-----------------------------------------------------------


On April 13, 2012, 1:18 a.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104557/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 1:18 a.m.)
> 
> 
> Review request for KDevelop and Alexandre Courbot.
> 
> 
> Description
> -------
> 
> Fix of this patch:
> https://git.reviewboard.kde.org/r/103448
> 
> Passes unit-tests and "QString" testcase.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/parser/parser.h 64b5c50 
>   languages/cpp/parser/parser.cpp a45ee31 
>   languages/cpp/parser/tests/test_parser.h 2869d9d 
>   languages/cpp/parser/tests/test_parser.cpp 94e3ee0 
> 
> Diff: http://git.reviewboard.kde.org/r/104557/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120413/2edfe73a/attachment.html>