Review Request: Use KAssistantDialog instead of QWizard for the new class assistant.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104547/#review12346
-----------------------------------------------------------


Hi!
Can we maybe have some screenshots of the result? Or something...

Or otherwise, I'm not sure what is the advantage of using KAssistantDialog.

- Aleix Pol Gonzalez


On April 11, 2012, 12:31 p.m., Ghislain Mary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104547/
> -----------------------------------------------------------
> 
> (Updated April 11, 2012, 12:31 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Use KAssistantDialog instead of QWizard for the new class assistant and use the "assistant" word instead of "wizard".
> 
> I tried to make as less changes as possible. I put the subtitle of the pages in the title of a groupbox and added an icon for each page.
> 
> 
> This addresses bug 181691.
>     http://bugs.kde.org/show_bug.cgi?id=181691
> 
> 
> Diffs
> -----
> 
>   language/codegen/createclass.h 47b39f2378db24815f7a79b48bbd6c2a8211cf99 
>   language/codegen/createclass.cpp e52107f9d198f144d9d27a33a252b574cc6ed979 
>   language/codegen/overridespage.h 7bf3832fdc81543fd90ce7aec6b12bf32da97839 
>   language/codegen/overridespage.cpp 1a64f3de4ba4255c83fae23ef52a80b1071ca9ab 
>   language/codegen/ui/licensechooser.ui 21bea9476d875c9b56d883e569c09c08da1e89b3 
>   language/codegen/ui/newclass.ui 760eef6eed5c24ddbf0a2249450d1bd083c8c490 
>   language/codegen/ui/outputlocation.ui 09110cc01a74c5f938f3df8b3e21e326ffc11280 
>   language/codegen/ui/overridevirtuals.ui dbf9abe7053dfd9403f6b788bf33192aa553074b 
> 
> Diff: http://git.reviewboard.kde.org/r/104547/diff/
> 
> 
> Testing
> -------
> 
> Created several classes, overriding some classes or not.
> Also tried to go back in the assistant to make changes on one of the previous pages.
> 
> 
> Thanks,
> 
> Ghislain Mary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120412/8c1be16e/attachment.html>