Review Request: Allow to pass multiple targets and build variables to the make builder

[Alexandre Courbot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104537/
-----------------------------------------------------------

(Updated April 11, 2012, 2:13 a.m.)


Review request for KDevelop.


Changes
-------

New patch taking Aleix's remarks into account.


Description
-------

This change augments the IMakeBuilder interface and MakeBuilder class to let them support the following:

1) Let make be run with multiple targets to build in one run
2) Pass build variables as a QMap of (variable, value) pairs that are also passed to make's command line.

E.g. this change now makes it possible for the make builder to perform make invokations that look like the following (example taken from an actual Linux kernel build):

$ make ARCH=arm CROSS_COMPILE=/usr/bin/arm-elf- vmlinux modules

API compatibility is not broken, but ABI is as the former virtual method of IMakeBuilder is now an inline function.


Diffs (updated)
-----

  projectbuilders/makebuilder/imakebuilder.h 56735425d78551883f109e942145eba2aa982687 
  projectbuilders/makebuilder/makebuilder.h 34881c6eaee775b6b8b53959dfcf825732e806da 
  projectbuilders/makebuilder/makebuilder.cpp 6c6905db30f469958f4a0048826febea29bad15a 
  projectbuilders/makebuilder/makejob.h 19032fdf371da793d52b3457e5aa78a6b8458150 
  projectbuilders/makebuilder/makejob.cpp ad5636dbfdadf3ae18ad1cc5b8dff078dd34cd42 

Diff: http://git.reviewboard.kde.org/r/104537/diff/


Testing
-------

Ensured API remained compatible and prior API behaved identically, tested build variables with the kdev-kernel plugin that uses them.


Thanks,

Alexandre Courbot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120411/39bb0b13/attachment.html>