Review Request: Make quickopen filter timeout depend on how many items need to be searched

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104486/#review12189
-----------------------------------------------------------


as I said, I'm opposed to this patch but please ask our users on our mailing lists and see what they think.

I think that the timeout should be related to the typing-speed, and not to the number of items in the model. applying a filter after 10ms makes no sense at all, then we could just apply it instantaneously...

maybe just get rid of that interpolation and make it ("more than XYZ items" -> "apply filter after 150ms").


plugins/quickopen/quickopenmodel.cpp
<http://git.reviewboard.kde.org/r/104486/#comment9588>

    use rowcount



plugins/quickopen/quickopenmodel.cpp
<http://git.reviewboard.kde.org/r/104486/#comment9589>

    remove this



plugins/quickopen/quickopenplugin.cpp
<http://git.reviewboard.kde.org/r/104486/#comment9590>

    this should be changed as soon as the number of items in the model changes, so you'll have to connect to some signal


- Milian Wolff


On April 5, 2012, 12:42 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104486/
> -----------------------------------------------------------
> 
> (Updated April 5, 2012, 12:42 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I find the recently introduced 150ms-timeout for searching quickopen very annoying, as I loved the instant feedback quickopen had before. It is clear that something like the timer is necessary for large projects, because the items cannot be searched in real-time; however, for smaller projects (and especially for the outline filter!) the additional delay is just plain unnecessary.
> 
> This patch adjusts the delay to the amount of items to be searched; it is 0 if the amount of items to be searched is less than 5000, and reaches its maximum of 150ms (the old default value) if there's more than 50.000 items. Those values are just random, and better suggestions are welcome.
> 
> An immediately noticeable positive effect of this patch (in every project) is that the outline widget now again always provides instant, smooth feedback.
> 
> 
> Diffs
> -----
> 
>   plugins/quickopen/quickopenmodel.h 3da9f1c 
>   plugins/quickopen/quickopenmodel.cpp 6fd9c89 
>   plugins/quickopen/quickopenplugin.cpp 91a9211 
> 
> Diff: http://git.reviewboard.kde.org/r/104486/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120405/24f7c6d7/attachment.html>