Review Request: Allow language plugins to choose whether a file must be reparsed on whitespace changes or not

Sven Brauch svenbrauch at gmx.de
Sun Apr 1 12:52:29 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104453/
-----------------------------------------------------------

(Updated April 1, 2012, 12:52 p.m.)


Review request for KDevelop.


Changes
-------

add missing saftey check


Description
-------

Python requires files to be re-parsed on whitespace changes, because the indentation is part of the language syntax. This patch adds a virtual function to ILanguageSupport which can be overwritten by language plugins if they require files to be re-parsed on whitespace changes. The default implementation returns false, so all existing plugins are unaffected.


Diffs (updated)
-----

  language/backgroundparser/documentchangetracker.cpp 79e63a9 
  language/interfaces/ilanguagesupport.h b3cc9eb 
  language/interfaces/ilanguagesupport.cpp 94c1f72 

Diff: http://git.reviewboard.kde.org/r/104453/diff/


Testing
-------

Seems to work okay.


Thanks,

Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120401/3aba494c/attachment.html>


More information about the KDevelop-devel mailing list