Review Request: Make include paths not starting with '/' relative
Milian Wolff
mail at milianw.de
Sat Sep 17 14:35:31 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102644/#review6591
-----------------------------------------------------------
Ship it!
one minor change then it's ok from my side.
languages/cpp/includepathresolver.cpp
<http://git.reviewboard.kde.org/r/102644/#comment5826>
please cache the QDir as this can be expensive when done often
- Milian
On Sept. 17, 2011, 4:48 a.m., Alexandre Courbot wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102644/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2011, 4:48 a.m.)
>
>
> Review request for KDevelop.
>
>
> Summary
> -------
>
> Make include paths not starting with '/' relative
>
> Convert paths in .kdev_include_paths that do not start with '/'
> into absolute paths by concatenating them to the storage
> directory.
>
>
> Diffs
> -----
>
> languages/cpp/codegen/ui/custom_include_paths.ui f4695de81ad4de0fc2d007deb76935506cf2a0eb
> languages/cpp/includepathresolver.cpp 13174fd47a0d34f11802ed70af14bc5bc0025c9b
>
> Diff: http://git.reviewboard.kde.org/r/102644/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexandre
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110917/6cff076c/attachment.html>
More information about the KDevelop-devel
mailing list