Review Request: Allow private members to be declared on missing declarations in member init lists
Jonas Jacobi
jonas.jacobi at web.de
Thu Sep 15 15:42:03 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102620/
-----------------------------------------------------------
Review request for KDevelop.
Summary
-------
Currently, only public member variables can be created, if one uses an unknown declaration in the member init list of a c'tor like
MyClass::MyClass(int x) : mUnknown(x) {}
This patch also allows to create a private member.
Please look especially at the following question as i'm new to duchain:
- can this part of the code be called from a context, where it doesn't make sense to create a private member?
While imho the default case should be a private member, we could also allow protected ones, or maybe even discard the public case, to support good coding style with encapsulation ;).
Diffs
-----
languages/cpp/cppduchain/missingdeclarationassistant.cpp bafc159
Diff: http://git.reviewboard.kde.org/r/102620/diff
Testing
-------
Screenshots
-----------
http://git.reviewboard.kde.org/r/102620/s/261/
Thanks,
Jonas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110915/3268b4ec/attachment.html>
More information about the KDevelop-devel
mailing list