Review Request: Include resolving using 'make' optional

[Alexandre Courbot]

> On Oct. 18, 2011, 12:01 a.m., Milian Wolff wrote:
> > languages/cpp/includepathresolver.cpp, line 709
> > <http://git.reviewboard.kde.org/r/102883/diff/1/?file=38984#file38984line709>
> >
> >     this will break the cases where you just open a few files in a make-based source code tree (with in-source build) without first opening a project.
> >     
> >     but fair enough, this case is rare and maybe not that important anyways, as hopefully people are using out-of-source builds anyways these days.
> >     
> >     yet afair there is even a way to configure the out-of-source build dir via the "missing include" assistant...
> >     
> >     so yeah, make it = true by default please.

Indeed, this should be true by default.


- Alexandre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102883/#review7457
-----------------------------------------------------------


On Oct. 16, 2011, 8:31 a.m., Alexandre Courbot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102883/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2011, 8:31 a.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Description
> -------
> 
> Include resolving using 'make' optional
> 
> Make can be invoked by the background parser if some include paths are
> unresolved. However some projects do not use make for building and this
> potentially induces an overhead for large projects. This patch adds a
> project-wide option to disable this behavior.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/includepathresolver.cpp d0b1cc1ede30409f77123573b269ea866a71ff96 
>   projectbuilders/makebuilder/makebuilderconfig.kcfg 8b521f12a92ce1bddef51c6a4a4126d8c9d1893c 
>   projectbuilders/makebuilder/makeconfig.ui 6c047c1bda5ec8ffc9af98546a33d083e065185b 
> 
> Diff: http://git.reviewboard.kde.org/r/102883/diff/diff
> 
> 
> Testing
> -------
> 
> Checked that the setting is correctly set and taken into account by the IncludePathResolver.
> 
> 
> Thanks,
> 
> Alexandre Courbot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111019/d612109d/attachment.html>