Review Request: Include resolving using 'make' optional

[Alexandre Courbot]

> On Oct. 16, 2011, 11:01 p.m., Aleix Pol Gonzalez wrote:
> > languages/cpp/includepathresolver.cpp, line 711
> > <http://git.reviewboard.kde.org/r/102883/diff/1/?file=38984#file38984line711>
> >
> >     Have you considered if this takes a lot of time? Maybe we could cache this in some way?

Yes, see my first comment - actually I would like to get the project passed along the parse jobs and path computer to avoid doing that. Not sure if this is the right thing to do though, so I posted the code as is to get comments.


> On Oct. 16, 2011, 11:01 p.m., Aleix Pol Gonzalez wrote:
> > languages/cpp/includepathresolver.cpp, line 733
> > <http://git.reviewboard.kde.org/r/102883/diff/1/?file=38984#file38984line733>
> >
> >     Maybe I'm missing something... Why is this removed? Does it work at all?

This variable was not used at all in the code.


- Alexandre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102883/#review7413
-----------------------------------------------------------


On Oct. 16, 2011, 8:31 a.m., Alexandre Courbot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102883/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2011, 8:31 a.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Description
> -------
> 
> Include resolving using 'make' optional
> 
> Make can be invoked by the background parser if some include paths are
> unresolved. However some projects do not use make for building and this
> potentially induces an overhead for large projects. This patch adds a
> project-wide option to disable this behavior.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/includepathresolver.cpp d0b1cc1ede30409f77123573b269ea866a71ff96 
>   projectbuilders/makebuilder/makebuilderconfig.kcfg 8b521f12a92ce1bddef51c6a4a4126d8c9d1893c 
>   projectbuilders/makebuilder/makeconfig.ui 6c047c1bda5ec8ffc9af98546a33d083e065185b 
> 
> Diff: http://git.reviewboard.kde.org/r/102883/diff/diff
> 
> 
> Testing
> -------
> 
> Checked that the setting is correctly set and taken into account by the IncludePathResolver.
> 
> 
> Thanks,
> 
> Alexandre Courbot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111017/2e77531b/attachment.html>