Review Request: Git commit message formatting

Sergey Vidyuk sir.vestnik at gmail.com
Mon Oct 17 03:05:18 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102857/
-----------------------------------------------------------

(Updated Oct. 17, 2011, 3:05 a.m.)


Review request for KDevelop.


Changes
-------

Default implementation of the setupCommitMessageEditor is moved into the cpp file


Description
-------

Added ability to customize commit message text edit from a VCS plugin
Added git commit message highlighting based on the guidelines from http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html (This article rules are used in vim formatting git commit message syntax highlighter).


Diffs (updated)
-----

  plugins/git/CMakeLists.txt 882e0a0 
  plugins/git/gitmessagehighlighter.h PRE-CREATION 
  plugins/git/gitmessagehighlighter.cpp PRE-CREATION 
  plugins/git/gitplugin.h 3f7f1af 
  plugins/git/gitplugin.cpp 7040c7e 
  plugins/git/tests/CMakeLists.txt 81621ca 
  vcs/CMakeLists.txt a95975a 
  vcs/interfaces/ibasicversioncontrol.h cb769a5 
  vcs/interfaces/ibasicversioncontrol.cpp PRE-CREATION 
  vcs/widgets/vcsdiffpatchsources.cpp 66ade13 

Diff: http://git.reviewboard.kde.org/r/102857/diff/diff


Testing
-------

Manually tested


Thanks,

Sergey Vidyuk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111017/3088c6ab/attachment.html>


More information about the KDevelop-devel mailing list