Review Request: Better error handling in the BranchManager dialog

Aleix Pol Gonzalez aleixpol at gmail.com
Sun Oct 16 23:05:45 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102850/#review7415
-----------------------------------------------------------

Ship it!


Same as above. Send me a formatted patch and I'll push or I'll push this one.

- Aleix Pol Gonzalez


On Oct. 14, 2011, 12:50 p.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102850/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2011, 12:50 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
>  * Correct handling of cancel on enter new branch name dialog.
>  * Handling situation when current index is not set in the branches list.
>  * Set current index in the branches list in constructor.
> 
> 
> Diffs
> -----
> 
>   vcs/dvcs/ui/branchmanager.cpp 7de4776 
> 
> Diff: http://git.reviewboard.kde.org/r/102850/diff/diff
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111016/9d28eeb9/attachment.html>


More information about the KDevelop-devel mailing list