Review Request: Git commit message formatting

[Milian Wolff]

> On Oct. 14, 2011, 10:50 a.m., Sergey Vidyuk wrote:
> > plugins/git/gitmessagehighlighter.cpp, line 67
> > <http://git.reviewboard.kde.org/r/102857/diff/1/?file=38846#file38846line67>
> >
> >     Documentation states that it's called per block but never describes what is block. After several experiments I've discovered that block is always one line. Actually I don't know how to provide syntax highlighting of a git message without assumption that one block is one line.
> 
> Sergey Vidyuk wrote:
>     QTextEdit documentation says the following:
>     
>     QTextEdit works on paragraphs and characters. A paragraph is a formatted string which is word-wrapped to fit into the width of the widget. By default when reading plain text, one newline signifies a paragraph. A document consists of zero or more paragraphs. The words in the paragraph are aligned in accordance with the paragraph's alignment. Paragraphs are separated by hard line breaks. Each character within a paragraph has its own attributes, for example, font and color.
>     
>     So in case of plain text one block is one line.

you can split the block on \n and hence make sure you are actually just parsing one line at a time. imo you should do that to make sure this works in all cases.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102857/#review7325
-----------------------------------------------------------


On Oct. 14, 2011, 12:52 p.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102857/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2011, 12:52 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Added ability to customize commit message text edit from a VCS plugin
> Added git commit message highlighting based on the guidelines from http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html (This article rules are used in vim formatting git commit message syntax highlighter).
> 
> 
> Diffs
> -----
> 
>   plugins/git/CMakeLists.txt 882e0a0 
>   plugins/git/gitmessagehighlighter.h PRE-CREATION 
>   plugins/git/gitmessagehighlighter.cpp PRE-CREATION 
>   plugins/git/gitplugin.h 3f7f1af 
>   plugins/git/gitplugin.cpp 7040c7e 
>   plugins/git/tests/CMakeLists.txt 81621ca 
>   vcs/interfaces/ibasicversioncontrol.h cb769a5 
>   vcs/widgets/vcsdiffpatchsources.cpp 66ade13 
> 
> Diff: http://git.reviewboard.kde.org/r/102857/diff/diff
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111014/4d49ccd3/attachment.html>