Review Request: Git commit message formatting

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102857/#review7322
-----------------------------------------------------------



plugins/git/gitmessagehighlighter.h
<http://git.reviewboard.kde.org/r/102857/#comment6397>

    please uppercase the first char in enums



plugins/git/gitmessagehighlighter.cpp
<http://git.reviewboard.kde.org/r/102857/#comment6396>

    is this really called on a per-line basis? i.e. is text.length() *really* the line length?



vcs/interfaces/ibasicversioncontrol.h
<http://git.reviewboard.kde.org/r/102857/#comment6394>

    reword this:
    
    "Optionally apply VCS specific settings to the commit message editor.
    
    Overwrite this to set e.g. a default commit message or to setup highlighting or validation.
    
    The default implementation does nothing."



vcs/interfaces/ibasicversioncontrol.h
<http://git.reviewboard.kde.org/r/102857/#comment6395>

    don't make it pure virtual, provide an empty default implementation that does nothing and remove the dummy implementations from the other vcs plugins.


- Milian Wolff


On Oct. 14, 2011, 9:25 a.m., Sergey Vidyuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102857/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2011, 9:25 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Added ability to customize commit message text edit from a VCS plugin
> Added git commit message highlighting based on the guidelines from http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html (This article rules are used in vim formatting git commit message syntax highlighter).
> 
> 
> Diffs
> -----
> 
>   plugins/cvs/cvsplugin.h 9757d45 
>   plugins/git/CMakeLists.txt 882e0a0 
>   plugins/git/gitmessagehighlighter.h PRE-CREATION 
>   plugins/git/gitmessagehighlighter.cpp PRE-CREATION 
>   plugins/git/gitplugin.h 3f7f1af 
>   plugins/git/gitplugin.cpp 7040c7e 
>   plugins/git/tests/CMakeLists.txt 81621ca 
>   plugins/subversion/kdevsvnplugin.h 8bf36ae 
>   vcs/interfaces/ibasicversioncontrol.h cb769a5 
>   vcs/widgets/vcsdiffpatchsources.cpp 66ade13 
> 
> Diff: http://git.reviewboard.kde.org/r/102857/diff/diff
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> 
> Thanks,
> 
> Sergey Vidyuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111014/f58ab163/attachment.html>