Review Request: Small bug fix in git plugin branch creation
Sergey Vidyuk
sir.vestnik at gmail.com
Fri Oct 14 10:14:31 UTC 2011
> On Oct. 14, 2011, 9:54 a.m., Milian Wolff wrote:
> > this seems wrong, which version of git are you using? The "--" denotes 'last argument' and makes sure that branches starting with dashes or similar work as expected.
Just tried it in the command line and -- separator works. Looks like branch was not created due to another error: current index is not set in the branches list model until something is manually selected by the user. I've fixed this issue in http://git.reviewboard.kde.org/r/102850/
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102848/#review7316
-----------------------------------------------------------
On Oct. 14, 2011, 7:12 a.m., Sergey Vidyuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102848/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2011, 7:12 a.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> There is small bugfix for git plugin. Currently it's impossible to create new branch in git project from kdevelop ui due to incorrect job command line.
>
>
> Diffs
> -----
>
> plugins/git/gitplugin.cpp 7040c7e
>
> Diff: http://git.reviewboard.kde.org/r/102848/diff/diff
>
>
> Testing
> -------
>
> Manual testing
>
>
> Thanks,
>
> Sergey Vidyuk
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111014/dc0912e9/attachment.html>
More information about the KDevelop-devel
mailing list