Review Request: Fix opening of tabs when using buddy documents and split views

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102806/#review7259
-----------------------------------------------------------

Ship it!


sounds fine to me, please push.

don't forget the "REVIEW: 102806" line in your commit message to close this review.

bye

- Milian Wolff


On Oct. 8, 2011, 3:43 p.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102806/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2011, 3:43 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> With the "Arrange related documents side by side" option checked, switching between declaration/definition could lead to files getting opened multiple times on the same side in split view.
> 
> 
> This addresses bug 277642.
>     http://bugs.kde.org/show_bug.cgi?id=277642
> 
> 
> Diffs
> -----
> 
>   shell/documentcontroller.cpp 684fd53 
>   shell/tests/shellbuddytest.h 2f8cd9d 
>   shell/tests/shellbuddytest.cpp b65aeec 
> 
> Diff: http://git.reviewboard.kde.org/r/102806/diff/diff
> 
> 
> Testing
> -------
> 
> Workflow described in the bug, plus I added a unit test.
> 
> 
> Thanks,
> 
> Lambert CLARA
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111012/671e26a9/attachment.html>